-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Feature/refl cpp #4169
WIP Feature/refl cpp #4169
Conversation
Why did adding that model require changing the way parameters are assigned to structs? Just out of curiosity, I was struck by seeing 39 files changed just to add a model. It amuses me a bit because I sometimes do unnecessary things when I get excited 😂😂. |
Well what's happening is that there is an unnamed type information that's
being injected into the base class which is now messing up the default
Constructors
…On Wed, Nov 22, 2023, 15:33 Steward Garcia ***@***.***> wrote:
Why did adding that model require changing the way parameters are assigned
to structs? Just out of curiosity, I was struck by seeing 39 files changed
just to add a model. It amuses me a bit because I sometimes do unnecessary
things when I get excited 😂😂.
—
Reply to this email directly, view it on GitHub
<#4169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KQ2M2O6VKXQW4VLL5T2TYFZORNAVCNFSM6AAAAAA7WJSB42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGQ3TAMBQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I thank you also for even looking at my work, this is still very much work
in progress, i am evaluating the different meta programming libs. Maybe
these changes wont be needed, aslo there are changes from my previous
patches rolled into this. I will need longer to conclude this working and
buliding in public, I hope that it inspires someone to join my effort.
…On Wed, Nov 22, 2023, 15:48 Jim Dupont ***@***.***> wrote:
Well what's happening is that there is an unnamed type information that's
being injected into the base class which is now messing up the default
Constructors
On Wed, Nov 22, 2023, 15:33 Steward Garcia ***@***.***>
wrote:
> Why did adding that model require changing the way parameters are
> assigned to structs? Just out of curiosity, I was struck by seeing 39 files
> changed just to add a model. It amuses me a bit because I sometimes do
> unnecessary things when I get excited 😂😂.
>
> —
> Reply to this email directly, view it on GitHub
> <#4169 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AD5KQ2M2O6VKXQW4VLL5T2TYFZORNAVCNFSM6AAAAAA7WJSB42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGQ3TAMBQGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
the first type names are being printed
So I have made progress on this, it turns out this lib needs a bunch of macros, I am working on the generator for them now. |
https://github.com/meta-introspector/llama.cpp/blob/feature/refl-cpp/binding.py this generator started to generate the bindings for me using a llvm and python |
https://github.com/meta-introspector/llama.cpp/blob/feature/refl-cpp/print.hpp this is the place where I put the generated wrappers |
#4209 now reworked the patch to be smaller |
Now I reworked it to be much smaller patch please check it out #4209 |
WIP adding refl cpp
based on my previous cpp work. https://github.com/veselink1/refl-cpp provides a single header. I am experimenting with it, first version that compiled. Adding a new base class to everything, not sure if that is needd.